-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: position_step()
#6228
Comments
I've come to realise that we could even generalise on the step adjustment by allowing arbitrary connections between points. |
one consideration/complication for ribbons is how to close the last part of ribbon especially if it is a CI around say a geom_stop of a kaplan meier curves: |
Thanks for the links @smouksassi! I have the feeling like I'm missing some subtlety here. Do KMCs have some special rules about how the steps should be drawn? I think {ggsurvfit}, which I trust on their KMCs, uses |
harrelfe/rms#70 |
If we now already have 4 examples of packages had to reimplement the steps, then I suppose that indicates some need to support this at the base ggplot2 level beyond |
We now have
geom_step()
. The 'step' adjustment to the line could in theory work with other geometries as well, notablygeom_area()
or evengeom_ribbon()
. The proposal here is to make aposition_step()
and deprecateGeomStep
in favour ofGeomLine
+PositionStep
.The text was updated successfully, but these errors were encountered: