Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message for "One or more parsing issues" contains difficult to follow instruction dat <- vroom(...) #1485

Closed
charliejhadley opened this issue Mar 20, 2023 · 2 comments
Labels
reprex needs a minimal reproducible example

Comments

@charliejhadley
Copy link

There's been some awesome work on the on the warning messages for {readr}! However, I feel for inexperienced users the instructions are confusing.

The following error message is generated if vroom detects unexpected input:

Warning message:
One or more parsing issues, call `problems()` on your data frame for details, e.g.:
  dat <- vroom(...)
  problems(dat) 

For a {tidyverse} user who only has the core tidyverse loaded they're not going to be able to run dat <- vroom(...) as they don't have {vroom} loaded.

However, I note that the error comes from vroom_errors.h in the {vroom} package... so it might not be convenient to figure out if the user has {vroom} loaded or not at the point when the error is generated.

https://github.com/tidyverse/vroom/blob/a7769d1f9216216cfd8fdc96fbde9360fe59b598/src/vroom_errors.h#L94

I think it is worth questioning if this is a useful instruction for inexperienced users even if it is decided this is the best error that can be generated.

@hadley hadley added the reprex needs a minimal reproducible example label Jul 31, 2023
@hadley
Copy link
Member

hadley commented Jul 31, 2023

Can you please provide a minimal reprex (reproducible example)? The goal of a reprex is to make it as easy as possible for me to recreate your problem so that I can fix it: please help me help you! If you've never heard of a reprex before, start by reading about the reprex package, including the advice further down the page. Please make sure your reprex is created with the reprex package as it gives nicely formatted output and avoids a number of common pitfalls.

@hadley
Copy link
Member

hadley commented Jul 31, 2023

Duplicate of #1477

@hadley hadley marked this as a duplicate of #1477 Jul 31, 2023
@hadley hadley closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reprex needs a minimal reproducible example
Projects
None yet
Development

No branches or pull requests

2 participants