Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep "I" capitalized in str_to_sentence for the "en" locale #498

Closed
ZIBOWANGKANGYU opened this issue Feb 2, 2023 · 1 comment
Closed

Comments

@ZIBOWANGKANGYU
Copy link

Currently, the single upper-case letter "I" is changed to "i" if it appears in the middle of a sentence.

> stringr::str_to_sentence("THIS IS WHAT I MEAN!")
[1] "This is what i mean!"

It might be a good idea to keep "I" capitalized. Sorry if this discussion is more suitable for the stringi package.

@hadley
Copy link
Member

hadley commented Aug 4, 2023

This function is a very thin wrapper around stri_trans_totitle(), so stringi would be the write place to file an issue.

@hadley hadley closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants