Fix bug in str_trunc() with simpler code
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this fix is cleaner. Looked at speed; they're equivalent. |
hadley
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Thanks for working on this! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
|
I have updated NEWS.md. Please check it. |
hadley
reviewed
Aug 5, 2023
NEWS.md
Outdated
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| ## Breaking changes | |||
|
|
|||
| * `str_trunc()` now correctly truncates strings when `side` is `"left"` or | |||
There was a problem hiding this comment.
Can you please put this in the news for the development version?
There was a problem hiding this comment.
Sorry for the mistake. I just fixed it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #512 .
This is a pull request similar to #513 .
#512 is caused by the boundary cases of
stringi::stri_sub()when getting the end of a string.gagolews/stringi#494
I modified the code to avoid the boundary cases, i.e.,
fromis always a positive number, and added tests.I think this proposal can fix the bug with simpler code than #513 .