Skip to content

Hard-deprecate trunc_mat() #960

Open

Description

@krlmlr

Activity

  1. added this to the 3.1.6 milestone on Oct 18, 2021
  2. changed the title [-]Remove colonnade() reexport[/-] [+]Remove use of colonnade()[/+] on Oct 25, 2021
  3. modified the milestones: 3.1.6, 4.0.0 on Oct 25, 2021
  4. changed the title [-]Remove use of colonnade()[/-] [+]Hard-deprecate trunc_mat() to remove use of colonnade()[/+] on Oct 25, 2021
  5. krlmlr commented on Dec 25, 2021

    @krlmlr
    MemberAuthor
  6. krlmlr commented on Jan 2, 2022

    @krlmlr
    MemberAuthor
  7. krlmlr commented on Feb 23, 2023

    @krlmlr
    MemberAuthor
  8. krlmlr commented on Mar 18, 2025

    @krlmlr
    MemberAuthor

    colonnade() now hard-deprecated in pillar.

  9. changed the title [-]Hard-deprecate trunc_mat() to remove use of colonnade()[/-] [+]Hard-deprecate `trunc_mat()`[/+] on Mar 18, 2025
  10. moodymudskipper commented on Mar 22, 2025

    @moodymudskipper

    The 'tibble' package uses the 'lifecycle' package to handle the deprecation cycle.

    From ? deprecate_soft :

    • deprecate_soft() warns only if the deprecated function is called directly, i.e. a user is calling a function they wrote in the global environment or a developer is calling it in their package. It does not warn when called indirectly, i.e. the deprecation comes from code that you don't control.
    • deprecate_warn() warns unconditionally.
    • deprecate_stop() fails unconditionally.`

    trunc_mat() contains a calls to deprecate_soft(), we want deprecate_warn() instead (+ Update in the NEWS).

  11. moodymudskipper commented on Mar 26, 2025

    @moodymudskipper

    @krlmlr do we want deprecate_warn()or deprecate_stop() I'm not sure now

  12. krlmlr commented on Mar 26, 2025

    @krlmlr
    MemberAuthor

    Responded offline, stop() is better. The NEWS update is handled by fledge here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions