Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile on R4.4 #538

Open
pipedream opened this issue May 2, 2024 · 9 comments
Open

Fails to compile on R4.4 #538

pipedream opened this issue May 2, 2024 · 9 comments

Comments

@pipedream
Copy link

Vroom does not compile on R4.4 for me.

I am using Debian 12, gcc 12.2.0, and R4.4 from cran.
vroom.log

@dtmvandenberg
Copy link

Getting the exact same error messages on Ubuntu 22.04 with gcc 11.4.0 and R 4.4.0.

@DavisVaughan
Copy link
Member

DavisVaughan commented May 2, 2024

Update cpp11 to the CRAN version, i.e. 0.4.7, and try again. That should fix it. See r-lib/cpp11#345

@DavisVaughan
Copy link
Member

It looks like you may also need to update the progress package to its CRAN version as well, i.e. 1.2.3, see r-lib/progress@367dbb0

@pipedream
Copy link
Author

pipedream commented May 2, 2024

Thank you.

I did NOT need to upgrade either of the Debian 12 packages

  • r-cran-cpp11 (0.4.3-1)
  • cpp-12

All I needed to fix it was:
install.packages("progress")

It fetched progress 1.2.3 into /usr/local/lib (in addition to the debian package of progress 1.2.2 in /usr/lib) and then vroom installed.

@DavisVaughan
Copy link
Member

You'll still get compilation warnings about cpp11 unless you update that too, but you're right that the logs suggest that the progress case was the one that was causing the error

@arne-henningsen
Copy link

So should the "vroom" and "readxl" packages (and perhaps also some other packages) 'depend' on (a certain version of) the "progress" package to avoid this problem? Or could at least the error message be improved so that users who experience the problem can read how they can fix the problem?

@jennybc
Copy link
Member

jennybc commented May 2, 2024

Well, their dependence on a specific version is specific to R 4.4 which just got released. So I think we'll bump the minimum version of progress next time we release. I'm not sure that this alone is worth a release of these packages.

@DavisVaughan
Copy link
Member

@jennybc you've actually done that already #526

@jennybc
Copy link
Member

jennybc commented May 2, 2024

I love past me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants