Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe current maintenance posture #421

Merged
merged 9 commits into from
Apr 12, 2022
Merged

Describe current maintenance posture #421

merged 9 commits into from
Apr 12, 2022

Conversation

sbearrows
Copy link
Contributor

@sbearrows sbearrows commented Mar 23, 2022

Closes #186, closes #151, closes #250, closes tidyverse/readr#1316

@sbearrows sbearrows requested a review from jennybc March 23, 2022 17:34
MAINTENANCE.md Outdated Show resolved Hide resolved
MAINTENANCE.md Outdated Show resolved Hide resolved
MAINTENANCE.md Outdated Show resolved Hide resolved
@jennybc
Copy link
Member

jennybc commented Mar 23, 2022

I am expecting to see some sort of a bullet list appear in the new section and #186 will be on it. As it stands, the reason that this PR closes that issue is very implicit (vs. explicit).

@jennybc jennybc changed the title Update maintenance docs Describe current maintenance posture Mar 23, 2022
@jennybc
Copy link
Member

jennybc commented Apr 1, 2022

The main / initial comment still needs to gain a bunch of "Closes #(some issue or PR number)". But otherwise, I entrust this to your hands.

@jennybc
Copy link
Member

jennybc commented Apr 1, 2022

I moved the "closes" statements into the initial comment.

@sbearrows
Copy link
Contributor Author

@jennybc I'm not able to merge this probably because it was moved to a new org

@jennybc
Copy link
Member

jennybc commented Apr 12, 2022

Just to be clear: @sbearrows you'd like me to merge this?

@sbearrows
Copy link
Contributor Author

@jennybc Yes I'm ready to merge it, but also I think we need to change my permissions again since I'm blocked from merging.

@jennybc jennybc merged commit 8bdd2b5 into main Apr 12, 2022
@jennybc
Copy link
Member

jennybc commented Apr 12, 2022

@sbearrows Your permissions look correct. Perhaps this particular PR is weird, since I believe it pre-dated moving vroom from r-lib to tidyverse? I merged this and we'll just have to see if your inability to merge persists and dig further, if necessary.

@jennybc jennybc deleted the update-maintenance-docs branch April 12, 2022 16:35
@sbearrows
Copy link
Contributor Author

@jennybc Oh that might explain it. Alright, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants