Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate tolerations in kube-controllers deployment #3783

Open
wedaly opened this issue Feb 20, 2025 · 1 comment
Open

Duplicate tolerations in kube-controllers deployment #3783

wedaly opened this issue Feb 20, 2025 · 1 comment

Comments

@wedaly
Copy link

wedaly commented Feb 20, 2025

Tigera-operator currently appends c.cfg.Installation.ControlPlaneTolerations with rmeta.TolerateCriticalAddonsAndControlPlane in the kube-controllers deployment:

operator/pkg/render/kubecontrollers/kube-controllers.go

Line 636 in ed26c42

tolerations := append(c.cfg.Installation.ControlPlaneTolerations, rmeta.TolerateCriticalAddonsAndControlPlane...)

When the installation ControlPlaneTolerations includes CriticalAddonsOnly, the toleration is duplicated, which can cause errors in Prometheus as reported in Azure/AKS#4282
@caseydavenport
Copy link
Member

xref a similar issue: projectcalico/calico#8371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caseydavenport @wedaly