Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the approaches of spawning background jobs #1510

Open
ekexium opened this issue Nov 25, 2024 · 0 comments
Open

Unify the approaches of spawning background jobs #1510

ekexium opened this issue Nov 25, 2024 · 0 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@ekexium
Copy link
Contributor

ekexium commented Nov 25, 2024

In the current codebase, client-go provides several ways to spawn background or asynchronous tasks:

  • builtin go
  • kvstore.Go(func())
  • KVTxn.spawnWithStorePool

Using multiple approaches simultaneously may lead to issues such as data races (as seen in pingcap/tidb#57213).

We should standardize on a single approach to minimize risks and maintain code simplicity.
@cfzjywxk cfzjywxk added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfzjywxk @ekexium