Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix KeyException no retry & no detail error msg #778

Open
jackjeyis opened this issue Jan 18, 2024 · 0 comments
Open

fix KeyException no retry & no detail error msg #778

jackjeyis opened this issue Jan 18, 2024 · 0 comments
Labels
type/bug Something isn't working

Comments

@jackjeyis
Copy link
Contributor

Bug Report

1. Describe the bug

KeyException is known problem no need retry & no detail error msg

private boolean retryableException(Exception e) {
return e instanceof TiClientInternalException
|| e instanceof KeyException
|| e instanceof RegionException
|| e instanceof StatusRuntimeException;
}

public KeyException(Kvrpcpb.KeyError keyErr) {
super("Key exception occurred");
this.keyErr = keyErr;
}

2. Minimal reproduce step (Required)

3. What did you see instead (Required)

4. What did you expect to see? (Required)

private boolean retryableException(Exception e) {
return e instanceof TiClientInternalException
|| e instanceof RegionException
|| e instanceof StatusRuntimeException;
}

public KeyException(Kvrpcpb.KeyError keyErr) {
super("Key exception occurred " + keyErr.toString());
this.keyErr = keyErr;
}

5. What are your Java Client and TiKV versions? (Required)

  • Client Java: 3.3.5
  • TiKV:
@jackjeyis jackjeyis added the type/bug Something isn't working label Jan 18, 2024
jackjeyis pushed a commit to jackjeyis/client-java that referenced this issue Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant