Update VERSION check in configure script to use BRE #113
Conversation
POSIX BRE doesn't support `\+` so the grep fails on OpenBSD. Modify the version-check to use proper BRE
|
Welcome @Gumnos! It looks like this is your first PR to tikv/jemallocator 🎉 |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The link to the |
|
As per https://github.com/tikv/jemallocator/pull/113/checks?check_run_id=35052044761
|
|
Can you also send this PR to https://github.com/jemalloc/jemalloc? |
| @@ -8256,7 +8256,7 @@ done | |||
| # Check whether --with-version was given. | |||
| if test "${with_version+set}" = set; then : | |||
| withval=$with_version; | |||
| echo "${with_version}" | grep '^[0-9]\+\.[0-9]\+\.[0-9]\+-[0-9]\+-g[0-9a-f]\+$' 2>&1 1>/dev/null | |||
| echo "${with_version}" | grep '^[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*-[0-9][0-9]*-g[0-9a-f][0-9a-f]*$' 2>&1 1>/dev/null | |||
POSIX BRE doesn't support
\+so the grep fails on OpenBSD. Modify the version-check to use proper BREFixes #112