Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a prefixed registry, valid metric names are incorrectly marked as invalid #462

Open
tooboredtocode opened this issue Sep 25, 2022 · 0 comments

Comments

@tooboredtocode
Copy link

Describe the bug
Due to how Metrics are constructed, using a prefixed registry causes valid metric names to be marked as invalid
For example, if a registry has a valid prefix (such as backend), (yet) invalid metric name (such as 3rd_party_api_response_time) will turn into valid metric names (backend_3rd_party_api_response_time)

Given that the check currently happens in the constructor of the metrics and not in the registration, there is no way to construct such metrics besides abandoning the prefix utility and manually prefixing the metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant