-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode causal timestamp in storage module for RawKV APIV2 #13284
Labels
type/enhancement
The issue or PR belongs to an enhancement.
Comments
ti-chi-bot
added a commit
that referenced
this issue
Aug 22, 2022
ref #13284 Signed-off-by: haojinming <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
fengou1
pushed a commit
to fengou1/tikv
that referenced
this issue
Aug 30, 2022
ref tikv#13284 Signed-off-by: haojinming <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]> Signed-off-by: fengou1 <[email protected]>
ti-chi-bot
added a commit
that referenced
this issue
Sep 20, 2022
…13326) ref #13284 1. Encode ts in storage for raw modify interface 2. Use concurrency manager to lock rawkv ts to get rawkv resolved_ts in cdc. 3. Remove append ts in CausalObserver 4. Remove track/untrack raw ts in cdc scheduler. Will remove code in next PR as it make pr too big to review. Signed-off-by: haojinming <[email protected]> Co-authored-by: Ping Yu <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot
pushed a commit
that referenced
this issue
Sep 23, 2022
ref #13284 Signed-off-by: haojinming <[email protected]>
All PRs are merged in master branch. But there is still one issue unfixed: #13502. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Development Task
Encode ts in storage module can benifit from following aspects:
resolved_ts
, which is currently resolved by dead lock detection intikv/components/cdc/src/endpoint.rs
Line 913 in 7824699
To implement this, we need three PRs to achieve it:
raw_put
,raw_delete
,raw_batch_put
,raw_batch_delete
,raw_batch_put_atomic
,raw_batch_delete_atomic
,raw_compare_and_swap_atomic
. rawkv: Reuse scheduler worker pool for raw modify command #13286CausalObserver
. UseConcurrencyManager
to lock on-road key instead of cdc raw lock heap. rawkv: Encode ts to apiv2 key in storage instead of causal observer #13326resolved_ts
related code. cdc: Clean rawkv resolved ts code #13496The text was updated successfully, but these errors were encountered: