Skip to content

Commit 93ed7aa

Browse files
sahil839timabbott
authored andcommitted
settings: Fix check_property_changed code for user access setting.
The proposed_val for "realm_can_access_all_users_group" setting was always returning NaN value which resulted in the value being included in request even when it was not changed or disabled due to org not being on "Plus" plan. This resulted in a bug where user was not allowed to change the "guest" indicator setting on orgs without "Plus" plan. For orgs with "Plus" plan there was no problem in changing the setting but the save button was visible incorrectly if the setting was set to the initial value. This commit fixes both the bugs. (cherry picked from commit 4a98eb2)
1 parent dee5290 commit 93ed7aa

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

web/src/settings_components.js

+1
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,7 @@ export function check_property_changed(elem, for_realm_default_settings, sub, gr
510510
case "can_remove_subscribers_group":
511511
case "realm_create_multiuse_invite_group":
512512
case "can_mention_group":
513+
case "realm_can_access_all_users_group":
513514
proposed_val = get_dropdown_list_widget_setting_value($elem);
514515
break;
515516
case "email_notifications_batching_period_seconds":

0 commit comments

Comments
 (0)