Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashtag URL change #2

Open
kiwiot opened this issue Sep 24, 2015 · 3 comments
Open

hashtag URL change #2

kiwiot opened this issue Sep 24, 2015 · 3 comments

Comments

@kiwiot
Copy link
Contributor

kiwiot commented Sep 24, 2015

Line #55 no longer works - Replaced it with

$ret = preg_replace("/\B#(\w+)/", "<a href=\"http://twitter.com/hashtag/\\1?src=hash\" target=\"_blank\">#\\1</a>", $ret);

@jarednova
Copy link
Member

@kiwiot awesome! can you submit a PR?

@kiwiot
Copy link
Contributor Author

kiwiot commented Sep 24, 2015

Im afraid I dont know how to submit a pull request - to be fair I just dropped the code in with the git repo in it.

If you fire me the steps I can set this up differently and do that though

@kiwiot
Copy link
Contributor Author

kiwiot commented Sep 24, 2015

OK - had a crack at my first PR - hope I've done it right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants