Skip to content

Commit 5879ef2

Browse files
committed
fix: links
1 parent 5763c6f commit 5879ef2

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Writerside/topics/Compatibility-with-ProtoBuf.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Our implementation of ProtoBuf serialization supports a subset of ProtoBuf featu
55
## Unsupported ProtoBuf Features
66

77
1. **Types**:
8-
- **`uintXX` and `sfixedXX`**: Not supported due to limitations in `kotlinx.serialization.protobuf`.
8+
- **`sfixedXX`**: Not supported due to limitations in `kotlinx.serialization.protobuf`.
99

1010
2. **Options**:
1111
- **File and Message Options**: Not supported. For use cases requiring these features, please [open an issue](#).
@@ -17,12 +17,12 @@ Our implementation of ProtoBuf serialization supports a subset of ProtoBuf featu
1717
- **`google.protobuf.Any`**: Not supported. Arbitrary message types cannot be embedded.
1818
- **Reserved Fields**: Not supported. Reserved fields are ignored.
1919
- **Extensions**: Not supported. Custom fields must be defined within standard message structures.
20-
- **Proto2**: Not supported. Only Proto3 syntax is supported.
20+
- **Proto2**: Not supported. Only Proto3 syntax is supported, even though you may still use proto2 syntax with obvious limitations.
2121

2222
## Supported ProtoBuf Features
2323

2424
1. **Scalar Types**:
25-
- All scalar types are supported except `uintXX` and `sfixedXX`.
25+
- All scalar types are supported except `sfixedXX` (`kotlinx.serialization.protobuf` does not support this type at the moment).
2626

2727
2. **Complex Types**:
2828
- **Maps and Repeated Fields**: Fully supported, allowing for flexible data structures.
@@ -41,6 +41,6 @@ Our implementation of ProtoBuf serialization supports a subset of ProtoBuf featu
4141
6**Generated Protos**:
4242
- Protos generated from `.proto` files are supported similarly to user-defined protos.
4343

44-
For features not supported or additional requirements, please [open an issue](https://github.com/timemates/rrpc/issues/new/choose) to discuss potential support or contributions. This will help us understand and potentially address your use cases.
44+
For features not supported or additional requirements, please [open an issue](https://github.com/timemates/rrpc-kotlin/issues/new/choose) to discuss potential support or contributions. This will help us understand and potentially address your use cases.
4545

4646
You may also want to learn more about options and how they're handled [here](Kotlin-ProtoBuf-Options.md).

Writerside/topics/Implementation.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ For `ServerMetadata` it's the same.
3131
There are five types of requests in RSocket: Request-Response, Request-Stream, Request-Channel, Fire-And-Forget
3232
and Metadata-Push.
3333

34-
For now, we support only Request-Response, Request-Stream and Request-Channel:
34+
We support all types of those requests, but Fire-And-Forget and Metadata-Push are experimental:
3535

3636
| proto | Request Type |
3737
|-------------------------------------------------------|------------------|
@@ -42,13 +42,13 @@ For now, we support only Request-Response, Request-Stream and Request-Channel:
4242
| `rpc (timemate.rrpc.Ack) returns (timemate.rrpc.Ack)` | Metadata-Push |
4343

4444
Client-only streaming is not supported by transport (RSocket), so we don't support it either. We support other
45-
request types by annotation type called `Ack`, here's [an issue](https://github.com/timemates/rrpc/issues/9) to discuss.
45+
request types by annotation type called `Ack`, here's [an issue](https://github.com/timemates/rrpc-kotlin/issues/9) to discuss.
4646

4747

4848
___________________________________
4949

5050

51-
That's all what you probably need to know. Implementation is very simple and requires not a many efforts.
51+
That's all what you probably need to know. Implementation is very simple and requires no many efforts.
5252

5353

5454

0 commit comments

Comments
 (0)