client: extract DataFrame conversion
#123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the column exists in the dataframe prior to accessing it for conversion. Fixes timkpaine#121
The greeks and `volatility` columns will sometimes come back with the string `NaN` which results in an `object` dtype for the column. Force to a numeric with coercing errors to insert `numpy.NaN` instead.
Extract the `DataFrame` conversion into a module of helper functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the
DataFrameconversion into a module of helper functions, allowing reuse of previous calls. For example callingoptions()the underlying data is returned, butoptionsDF()does not parse this, previously the only way to get the underlying was to make an additional call.Also fixed #121 by checking for the column before conversion and added in explicit conversion to numeric types for the greeks and
volatilitycolumns.