Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for Protobuf 5 #40

Open
filbranden opened this issue Oct 24, 2024 · 4 comments
Open

Please add support for Protobuf 5 #40

filbranden opened this issue Oct 24, 2024 · 4 comments

Comments

@filbranden
Copy link

Help us help you

Planning a new virtual environment that includes Protobuf 5, more specifically protobuf==5.28.1, I'd like to request that a version of Tink that supports Protobuf 5 would be available

Is your feature request related to a problem?

Not a blocker right now, but planning to migrate applications to the new venv that includes Protobuf 5 and I expect the ones that use Tink will be blocked on this feature

What sort of feature would you like to see?

If support for Protobuf 5 is not backwards compatible, then possibly consider splitting into a new major version e.g. tink==2.0.0 with support for Protobuf 5, keeping a Tink 1.x branch for Protobuf <5 in case it still needs maintenance?

Have you considered any alternative solutions?

Not really, we have at least one app that went all in on Tink so we'd really like to have Tink with Protobuf 5 support available.

Would you like to add additional context?

Using Python 3.12

Thanks!

@top-oai
Copy link

top-oai commented Jan 10, 2025

Hi there, just wanted echo this desire... Is it just a matter of dropping the upper bound constraint?

@calderonth
Copy link

Yes please, this is quite problematic for us too when trying to use Tink in projects that rely on protobufs in 5.x, downgrading is not a great option.

@mouchar
Copy link

mouchar commented Feb 7, 2025

I noticed commit f86f602 solving this issue.
@juergw or @morambro - do you plan to cut a new release soon and publish wheels to PyPi?

@morambro
Copy link
Contributor

morambro commented Feb 7, 2025

Hi @mouchar, we are currently working on a new release. We don't have a precise timeline yet, but it should be ready by the end of March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants