Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI/CD, conventional commit enforcement, and auto release notes #13

Closed
deanefrati opened this issue Jun 18, 2024 · 4 comments · Fixed by #17 or #22
Closed

Add CI/CD, conventional commit enforcement, and auto release notes #13

deanefrati opened this issue Jun 18, 2024 · 4 comments · Fixed by #17 or #22
Assignees
Labels
enhancement New feature or request

Comments

@deanefrati
Copy link
Contributor

No description provided.

@deanefrati deanefrati added the enhancement New feature or request label Jun 18, 2024
@Lutherwaves
Copy link
Contributor

@Lutherwaves Lutherwaves self-assigned this Jun 23, 2024
@Lutherwaves Lutherwaves linked a pull request Jun 23, 2024 that will close this issue
@Lutherwaves Lutherwaves reopened this Jun 24, 2024
@Lutherwaves
Copy link
Contributor

Reopening as it was not completed, auto-closed by the PR that contributes to completing this

@Lutherwaves
Copy link
Contributor

Ok. so basically, there are a few main options:

Generally, I lean towards adding the Github Action for the following reasons:

  • Easily understand "what went wrong"
  • Not blocked on pushing your commits for testing/development (in Draft PRs for example)
  • Easier to manage, as pre-commit hooks can definitely be skipped
  • Easier to port across repos

The Cons of an Action would be

  • It can definitely be skipped if the team member deleted the Action from the .github folder - this can be mitigated by adding a ruleset on the Github Org/Repository to only allow a set of team members to edit the .github folder altogether
  • The failure is not left-shifted, and devs would need to wait for the pipeline to pass everytime they push; this may slow down things a tiny bit

@Lutherwaves
Copy link
Contributor

This is also neat https://github.com/siderolabs/conform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants