Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL storage adapter postgres implementation #2

Closed
deanefrati opened this issue Jun 18, 2024 · 7 comments · Fixed by #15
Closed

Add SQL storage adapter postgres implementation #2

deanefrati opened this issue Jun 18, 2024 · 7 comments · Fixed by #15
Assignees
Labels
enhancement New feature or request

Comments

@deanefrati
Copy link
Contributor

No description provided.

@deanefrati deanefrati added the enhancement New feature or request label Jun 18, 2024
@deanefrati deanefrati self-assigned this Jun 18, 2024
@Lutherwaves
Copy link
Contributor

@Lutherwaves
Copy link
Contributor

Gorm also has auto-migrate, which is why I picked it https://github.com/tink3rlabs/example-app/blob/main/internal/storage/client.go#L70

@deanefrati
Copy link
Contributor Author

Yes i saw gorm's auto-migrate but i would like to have the ability to do migrations for other adaptors as well so am not sure that using it would be cross platform enough.

@Lutherwaves
Copy link
Contributor

Which platforms do we aim to support? I think having an sql and no-sql adapter is close enough, we can't support everything.

I do plan on using MongoDB for example. Do we implement a mongodb adapter or a nosql adapter? Right now we have an sql adapter, but postgres is the focus, is it not a postgresadapter?

@deanefrati
Copy link
Contributor Author

deanefrati commented Jun 19, 2024

You're right I aim to support Postgres and Mysql in the SQL adapter but didn't implement the MySQL yet. I'll rename this to Postgres adapter and create a new issue for MySQL.

Generally speaking i agree we can't support everything so my plan for now is to support:

  • memory
  • SQL (postgres and mysql)
  • DynamoDB
  • Cassandra

Added #16 for mysql

@deanefrati deanefrati changed the title Add SQL storage adapter Add SQL storage adapter postgres implementation Jun 19, 2024
@Lutherwaves
Copy link
Contributor

As long as we are set up for scale (sql vs no-sql) we should be good. I've done some research and would probably contribute with a mongodb adapter - any concerns?

The reason for MongoDB and not cassandra is primarily tactical, it is just super simple to setup mongodb

@deanefrati
Copy link
Contributor Author

Definitely no concerns mongo is a popular option and would be good to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants