Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added leader election functionality #24

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Added leader election functionality #24

merged 2 commits into from
Jul 10, 2024

Conversation

deanefrati
Copy link
Contributor

@deanefrati deanefrati commented Jul 8, 2024 •
edited
Loading

Closes #3

ayashjorden
ayashjorden requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ayashjorden ayashjorden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions and questions

@ayashjorden
Copy link
Contributor

QQ, I see we're stringifying StorageAdapterTypes, Does Viper support unmarshalling to the desired Type? (can be in a separate issue/PR

@deanefrati
Copy link
Contributor Author

QQ, I see we're stringifying StorageAdapterTypes, Does Viper support unmarshalling to the desired Type? (can be in a separate issue/PR

Perhaps... i'll take a look and see if it's possible when working on the next issue.

@deanefrati deanefrati merged commit 82358ad into main Jul 10, 2024
4 checks passed
@deanefrati deanefrati deleted the leader_election branch July 10, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayashjorden ayashjorden ayashjorden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add leader election functionality
2 participants
@deanefrati @ayashjorden