Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateUser appears to create user if it doesn't exist #61

Open
jacobweinstock opened this issue Jan 7, 2021 · 0 comments
Open

UpdateUser appears to create user if it doesn't exist #61

jacobweinstock opened this issue Jan 7, 2021 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. PbnJ.next issues related to the new gRPC version of PBnJ priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@jacobweinstock
Copy link
Member

I'm still investigating but it appears that calls to UpdateUser rpc create the user if it doesn't exist.

Expected Behaviour

UpdateUser only updates existing users.

Current Behaviour

UpdateUser creates a new user if the user that is provided in the request does not already exist.

Possible Solution

we could refactor to check for user existence first.
@jacobweinstock jacobweinstock added kind/bug Categorizes issue or PR as related to a bug. PbnJ.next issues related to the new gRPC version of PBnJ labels Jan 7, 2021
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. PbnJ.next issues related to the new gRPC version of PBnJ priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tstromberg @jacobweinstock