Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable checking image dimensions #480

Open
akoufa opened this issue Jul 1, 2020 · 0 comments
Open

Disable checking image dimensions #480

akoufa opened this issue Jul 1, 2020 · 0 comments

Comments

@akoufa
Copy link
Contributor

akoufa commented Jul 1, 2020

Hello I opened PR: #479 to allow the users of the lib to disable the validation of the dimensions of the images to be added to the pass. I think the lib is currently too strict because testing the same assets with the apple tool I am able to create a pass. Nevertheless I extended the option object for users be able to pass the property disableImageCheck to disable explicitly the image check when needed. Can we proceed with merging the PR asap ? I need that functionality and it does not alter the default behaviour of the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants