-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UTM params support #50
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dce07a1
to
163a6d2
Compare
163a6d2
to
2b6ab8b
Compare
e49e86a
to
c51f7ea
Compare
@davidnmargulies @gnzjgo this would be an interesting one to get your review on how UTM params have been added to the Tinybird project. We could also do with some feedback on how we should handle/document upgrades/migrations from Workspaces uses the old version to this new version |
IMO we should not be doing upgrades to people's workspaces - we should communicate the changes, explain how to implement them, and let people do it themselves. This is a 'starter' kit after all, not a fully managed solution (although it would be nice to connect a workspace to a repo... not sure how that gels with 'iterating projects' but could be an interesting use case). For this specific change, the one wrinkle of complexity is that it changes an MV. We have to include really detailed instructions for people to create a new MV without breaking their flow. |
@davidnmargulies completely agree - I wasn't suggesting we forcibly migrate everyone 😅! What I meant was, we should work out what the migration process looks like, and work out how we document & communicate that to people who want to upgrade - because, as you say, the MV change has some complexity |
What about showing a message with instructions to set up the required Tinybird resources (data sources, pipes, endpoints, MVs, etc.) within the dashboard new components? Something like:
Maybe we could even add an "Upgrade" button in then Workspace home, where we already have the banner. |
Description
Dashboard
Tracker
Tinybird
Fixes #51
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: