Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTM params support #50

Closed
wants to merge 3 commits into from
Closed

Add UTM params support #50

wants to merge 3 commits into from

Conversation

dmytro-tinybird
Copy link
Contributor

@dmytro-tinybird dmytro-tinybird commented Jan 25, 2023

Description

Dashboard

  • Adds select for top sources widget with utm params and update for API call

Tracker

  • Adds utm params parsing from searchParams to _trackPageHit function

Tinybird

  • Adds utm params parsing and param for top sources API

Fixes #51

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have update the CHANGELOG
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
analytics-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 9:53AM (UTC)

@sdairs
Copy link
Collaborator

sdairs commented Jan 27, 2023

@davidnmargulies @gnzjgo this would be an interesting one to get your review on how UTM params have been added to the Tinybird project. We could also do with some feedback on how we should handle/document upgrades/migrations from Workspaces uses the old version to this new version

@davidnmargulies
Copy link

IMO we should not be doing upgrades to people's workspaces - we should communicate the changes, explain how to implement them, and let people do it themselves. This is a 'starter' kit after all, not a fully managed solution (although it would be nice to connect a workspace to a repo... not sure how that gels with 'iterating projects' but could be an interesting use case).

For this specific change, the one wrinkle of complexity is that it changes an MV. We have to include really detailed instructions for people to create a new MV without breaking their flow.

@sdairs
Copy link
Collaborator

sdairs commented Jan 30, 2023

@davidnmargulies completely agree - I wasn't suggesting we forcibly migrate everyone 😅! What I meant was, we should work out what the migration process looks like, and work out how we document & communicate that to people who want to upgrade - because, as you say, the MV change has some complexity

@alejandromav
Copy link
Member

@davidnmargulies completely agree - I wasn't suggesting we forcibly migrate everyone 😅! What I meant was, we should work out what the migration process looks like, and work out how we document & communicate that to people who want to upgrade - because, as you say, the MV change has some complexity

What about showing a message with instructions to set up the required Tinybird resources (data sources, pipes, endpoints, MVs, etc.) within the dashboard new components?

Something like:

Hey! We've added a new feature to the Dashboard, please follow these instructions to enable it.

Maybe we could even add an "Upgrade" button in then Workspace home, where we already have the banner.

@sdairs sdairs closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] UTM params support
5 participants