fix(core): use cfg-gated memory client and clean up test code

Split the `memory_client` method into two cfg-gated implementations so that test code builds a workspace-scoped client directly instead of relying on the global singleton, which is not booted under `cfg(test)`. Also replaced `vec!` with array literals, simplified iterator chains, and removed unnecessary `as_deref` calls across several modules to reduce allocations and improve clarity.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>

Author: senamakel

core/src/sync/composio/providers/types.rs

@@ -420,17 +420,20 @@ impl ProviderContext {
 
     /// Memory client handle if the global memory singleton is ready.
     /// Used by providers that want to persist sync snapshots.
+    ///
+    /// Under `cfg(test)` the global singleton is not booted, so build a
+    /// workspace-scoped client directly instead.
+    #[cfg(test)]
     pub fn memory_client(&self) -> Option<crate::store::MemoryClientRef> {
-        #[cfg(test)]
-        {
-            return crate::store::MemoryClient::from_workspace_dir(
-                self.config.workspace_dir().clone(),
-            )
+        crate::store::MemoryClient::from_workspace_dir(self.config.workspace_dir().clone())
             .ok()
-            .map(std::sync::Arc::new);
-        }
+            .map(std::sync::Arc::new)
+    }
 
-        #[cfg(not(test))]
+    /// Memory client handle if the global memory singleton is ready.
+    /// Used by providers that want to persist sync snapshots.
+    #[cfg(not(test))]
+    pub fn memory_client(&self) -> Option<crate::store::MemoryClientRef> {
         crate::global::client_if_ready()
     }
 }

core/src/tinycortex/persona.rs

@@ -345,7 +345,7 @@ mod tests {
 
     #[test]
     fn status_scan_stops_parsing_at_the_configured_limit() {
-        let paths = vec![PathBuf::from("one"), PathBuf::from("two")];
+        let paths = [PathBuf::from("one"), PathBuf::from("two")];
         let reads = std::cell::Cell::new(0);
         let status = source_status(
             "fixture",

core/src/tool_memory/test_helpers.rs

@@ -75,7 +75,7 @@ impl Memory for MockMemory {
                 .filter(|((n, _), _)| n == ns)
                 .map(|(_, v)| v.clone())
                 .collect(),
-            None => lock.iter().map(|(_, v)| v.clone()).collect(),
+            None => lock.values().cloned().collect(),
         })
     }
     async fn forget(&self, namespace: &str, key: &str) -> anyhow::Result<bool> {

core/src/tree/retrieval/benchmarks.rs

@@ -323,7 +323,7 @@ async fn bench_scale_ingest_20_sources_no_real_data() {
             &scope_str,
             &owner_str,
             vec![(
-                owner_str.clone().into(),
+                owner_str.clone(),
                 format!(
                     "Scale test message {} from {} — verifying retrieval correctness \
                      at volume with deterministic synthetic data. No PII present.",

core/src/tree/retrieval/integration_tests.rs

@@ -64,10 +64,9 @@ fn chat_about_phoenix(seq: u32) -> ChatBatch {
                 timestamp: Utc
                     .timestamp_millis_opt(1_700_000_001_000 + (seq as i64) * 10_000)
                     .unwrap(),
-                text: format!(
-                    "Confirmed. I'll handle coordination. #launch-q2 tracked in \
+                text: "Confirmed. I'll handle coordination. #launch-q2 tracked in \
                      Notion. bob@example.com will cut the release."
-                ),
+                    .to_string(),
                 source_ref: Some(format!("slack://phoenix/{seq}-reply")),
             },
         ],

core/src/tree/score/embed/factory.rs

@@ -158,8 +158,7 @@ fn resolve_embedder_choice(config: &Config) -> Result<EmbedderChoice> {
     // 2. Deliberate opt-out — vector search off by user choice.
     if config
         .embeddings_provider()
-        .as_deref()
-        .map(|s| s.trim())
+        .map(str::trim)
         .is_some_and(|s| s == "none")
     {
         return Ok(EmbedderChoice::OptOut);

core/src/tree/summarise.rs

@@ -28,7 +28,7 @@ pub async fn summarise(
     let Some(prepared) = tinycortex::memory::tree::prepare_summary_prompt(
         inputs,
         context,
-        config.output_language().as_deref(),
+        config.output_language(),
     ) else {
         return Ok(SummaryOutput::default());
     };