Commit 7d2dac0
committed
Keep the pin-bump non-breaking: four compat surfaces the audit found
The #18 end-to-end audit's downstream dimension resolved every path
OpenHuman imports (1,111 tokens across 33 shim files) against the
post-#48 tree. Four tinymemory-side breaks would have surfaced at the
next submodule pin bump; each gets the smallest surface that keeps the
old path resolving, marked for deletion once downstream migrates.
1. `pub use engine as tinycortex` (doc-hidden) at the core root.
OpenHuman re-exports `tinymemory_core::tinycortex` wholesale and 25
call sites reach through it; the §C1 rename would have made the bump
a coordinated two-repo edit for zero behavioural gain.
2. `SyncAuditEntry` re-exported from the engine seam. OpenHuman's
sources RPC embeds `memory::tinycortex::SyncAuditEntry` in a
response type. The type stays core-owned (§B1a); only the address is
preserved.
3. `extract_item_id` restored in sync_state. Deleted in §B1a as dead --
measured with too small a grep: OpenHuman's raw-coverage integration
tests import and exercise it through the pin.
4. `HostSyncAdapter` also implements core's `SyncStateStore`, beside
the engine trait of the same shape. Core's `SyncState::load`/`save`
take the core trait now, and OpenHuman pairs that type with this
adapter in its integration tests. Same KV calls; one storage, two
trait names during the transition.
Not fixed here, confirmed for the bump PR on OpenHuman's side: its
`store_golden.rs` seeder must absorb `fts5::episodic_insert` now
returning `Result<i64>` (main drift), and both its cargo workspaces
need a `[patch]` entry mapping tinymemory-api's git URL to the
submodule path before the vendored tinycortex resolves.
Also validated by the audit's refutation pass: the reported live
`MemoryClient::new_local()` caller was a stale checkout -- OpenHuman
main migrated to `active_memory_client()` in openhuman#5575.
cargo test -p tinymemory-core: 847 + e2e passed
cargo clippy --all-targets: clean
scripts/ci/engine-containment.sh: holds (the alias is `as tinycortex`,
not a `tinycortex::` code path)1 parent d1bdee2 commit 7d2dac0
4 files changed
Lines changed: 59 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
695 | 695 | | |
696 | 696 | | |
697 | 697 | | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
698 | 726 | | |
699 | 727 | | |
700 | 728 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
196 | 214 | | |
197 | 215 | | |
198 | 216 | | |
| |||
0 commit comments