Commit 8f0c818
committed
Fix the Docs build and address review
Three things, from CI and from review on #42.
Docs (CI failure)
-----------------
`RUSTDOCFLAGS="-D warnings" cargo doc` rejected
`[`UnifiedMemory`](crate::store::UnifiedMemory)` as a redundant explicit
link target -- the type is already imported at the top of this module, so
the bare form resolves on its own. A reference definition would have been
redundant for the same reason, so there is none.
`DriverRegistry::builtin` rustdoc (CodeRabbit)
---------------------------------------------
Valid: the doc still enumerated "the null placeholder, TinyCortex, and the
three supported native HTTP engines" after this PR added a fifth reserved
id. A registry whose doc does not list what it reserves is exactly the
drift the doc exists to prevent.
Lint scope (CodeRabbit)
-----------------------
Narrowed rather than removed. `expect_used` is `warn` workspace-wide
(Cargo.toml) and CI runs clippy with `-D warnings`, and `expect`'s message
is the failure diagnostic in a conformance test -- converting these to
`Result` would trade a named assertion for an anonymous `?`. Eight files
in this workspace carry the same attribute, including the sibling
`conformance_test.rs` this one is modelled on.
The finding did surface something real though: this file has seven
`expect` calls and no explicit `panic!`, so `clippy::panic` was never
needed. Dropped, leaving this file stricter than its siblings.
cargo fmt --all -- --check: clean
RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features -p tinymemory-core: clean
cargo test -p tinymemory-core --lib store::factories_provider_test: 5 passed1 parent 8977440 commit 8f0c818
3 files changed
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
360 | | - | |
| 360 | + | |
361 | 361 | | |
362 | 362 | | |
363 | 363 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
10 | 15 | | |
11 | 16 | | |
12 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
190 | | - | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
191 | 192 | | |
192 | 193 | | |
193 | 194 | | |
| |||
0 commit comments