Skip to content

Commit 9eb212f

Browse files
Revert "Carry the backend base URL into the module, so proxied Composio can address it"
1 parent fab01fb commit 9eb212f

5 files changed

Lines changed: 1 addition & 33 deletions

File tree

crates/tinymemory-module/src/config.rs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -164,22 +164,6 @@ pub struct ModuleConfig {
164164
/// a no-sync nobody can, this picks the one that can be noticed.
165165
pub memory_sync_interval_secs: Option<u64>,
166166

167-
/// Base URL of the OpenHuman backend, for proxied ("backend") Composio.
168-
///
169-
/// A field rather than a seam member, unlike the session bearer beside it,
170-
/// and the difference is what each thing is. A bearer is a credential that
171-
/// expires and gets refreshed, so a snapshot of it goes stale and has to be
172-
/// asked for per call. A base URL is routing configuration: it changes when
173-
/// an operator points the host at a different backend, which is a restart,
174-
/// not a mid-session event.
175-
///
176-
/// Empty means the host named none. The proxied branch of `composio_config`
177-
/// then builds its request against an empty base and fails inside the HTTP
178-
/// client with a builder error that names no cause — so a host that intends
179-
/// proxied mode must send this.
180-
#[serde(default)]
181-
pub backend_api_url: String,
182-
183167
/// How the host routes Composio calls: `backend` or `direct`.
184168
///
185169
/// Empty means the host stated no mode — an older host, or one with no
@@ -220,7 +204,6 @@ impl Default for ModuleConfig {
220204
local_ai: LocalAiConfig::default(),
221205
embeddings_provider: None,
222206
memory_provider: None,
223-
backend_api_url: String::new(),
224207
default_model: None,
225208
default_temperature: 0.0,
226209
output_language: None,

crates/tinymemory-module/src/provider.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ impl From<&ModuleConfig> for EngineRuntimeConfig {
3333
// mode, and both of those skip work rather than fail it.
3434
memory_sync_interval_secs: config.memory_sync_interval_secs,
3535
composio_mode: config.composio_mode.clone(),
36-
backend_api_url: config.backend_api_url.clone(),
3736
composio_entity_id: config.composio_entity_id.clone(),
3837
}
3938
}

crates/tinymemory-tinycortex/src/engine/mod.rs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,6 @@ pub struct EngineRuntimeConfig {
118118
/// answer backend mode gets, which is what an unset Composio integration
119119
/// should look like.
120120
pub composio_mode: String,
121-
/// Base URL of the host's backend, for proxied Composio. Empty when the
122-
/// host named none — see `effective_backend_api_url` below for why that is
123-
/// a refusal rather than a default.
124-
pub backend_api_url: String,
125121
/// The Composio entity the host authenticates as.
126122
///
127123
/// An identifier, not a credential: it selects whose connected accounts a
@@ -204,15 +200,8 @@ impl MemoryHostConfig for EngineRuntimeConfig {
204200
fn api_url(&self) -> Option<&str> {
205201
None
206202
}
207-
/// The host's backend base URL, verbatim.
208-
///
209-
/// No default is substituted for an empty one. Guessing a URL here would
210-
/// send a user's memory at whichever backend this crate happened to hard-code
211-
/// — including, for a self-hosted operator, one they do not control. An
212-
/// empty string fails inside the HTTP client instead, which is a bad error
213-
/// message and the right outcome.
214203
fn effective_backend_api_url(&self) -> String {
215-
self.backend_api_url.clone()
204+
String::new()
216205
}
217206
/// Always the named refusal, never `Ok(None)`.
218207
///

crates/tinymemory-tinycortex/src/engine/test.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ fn runtime_config() -> EngineRuntimeConfig {
5555
EngineRuntimeConfig {
5656
workspace_dir: "/workspace".into(),
5757
config_path: "/workspace/config.toml".into(),
58-
backend_api_url: String::new(),
5958
memory: Default::default(),
6059
memory_tree: Default::default(),
6160
scheduler_gate: Default::default(),
@@ -254,7 +253,6 @@ fn the_sync_cadence_is_answered_from_the_host_and_not_from_a_constant() {
254253
fn an_unstated_composio_mode_is_not_direct() {
255254
let config = EngineRuntimeConfig {
256255
composio_mode: String::new(),
257-
backend_api_url: String::new(),
258256
composio_entity_id: String::new(),
259257
..runtime_config()
260258
};

crates/tinymemory-tinycortex/tests/full_provider_conformance.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ fn provider_config(
118118
// sends.
119119
memory_sync_interval_secs: None,
120120
composio_mode: String::new(),
121-
backend_api_url: String::new(),
122121
composio_entity_id: String::new(),
123122
}
124123
}

0 commit comments

Comments
 (0)