Commit e006b67
committed
Carry the backend base URL into the module, so proxied Composio can address it
v1.8.0 gave the module a way to obtain a session bearer, which was necessary for
proxied Composio and not sufficient: `effective_backend_api_url` still answered
an empty string, so the request built against an empty base and failed inside
the HTTP client with `builder error` — a message that names neither the cause
nor the field.
Found by routing OpenHuman's Composio sync onto the driver and watching the run
get three provider actions in before dying on the transport. The bearer had
reached it; the address had not.
## A field, not a seam
The bearer is a seam because it is a credential that expires and gets refreshed,
so any snapshot of it goes stale. A base URL is the opposite kind of value:
routing configuration that changes when an operator points the host at a
different backend, which is a restart rather than a mid-session event. Carrying
it in `ModuleConfig` is both simpler and more honest about what it is.
## No default is substituted
An empty URL stays empty and fails in the HTTP client. Guessing one here would
send a user's memory at whichever backend this crate happened to hard-code —
including, for a self-hosted operator, a backend they do not control. A bad
error message is a much smaller problem than that, so the field is documented as
required for proxied mode rather than defaulted into looking optional.
`#[serde(default)]`, so a host that predates the field still loads.1 parent cd73b56 commit e006b67
5 files changed
Lines changed: 33 additions & 1 deletion
File tree
- crates
- tinymemory-module/src
- tinymemory-tinycortex
- src/engine
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
167 | 183 | | |
168 | 184 | | |
169 | 185 | | |
| |||
204 | 220 | | |
205 | 221 | | |
206 | 222 | | |
| 223 | + | |
207 | 224 | | |
208 | 225 | | |
209 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
121 | 125 | | |
122 | 126 | | |
123 | 127 | | |
| |||
200 | 204 | | |
201 | 205 | | |
202 | 206 | | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
203 | 214 | | |
204 | | - | |
| 215 | + | |
205 | 216 | | |
206 | 217 | | |
207 | 218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
| |||
253 | 254 | | |
254 | 255 | | |
255 | 256 | | |
| 257 | + | |
256 | 258 | | |
257 | 259 | | |
258 | 260 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
121 | 122 | | |
122 | 123 | | |
123 | 124 | | |
| |||
0 commit comments