Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function definition and Function implementation does not match #4

Open
AshStuff opened this issue Dec 29, 2017 · 4 comments
Open

Function definition and Function implementation does not match #4

AshStuff opened this issue Dec 29, 2017 · 4 comments

Comments

@AshStuff
Copy link

@ line 246. The function starts with _bn_relu_conv() but you have implemented as conv --> batch_norm --> relu

@relh
Copy link

relh commented Jan 24, 2018

If you go here you can see that it was the way you described before @titu1994 changed it: f9eaf9a.

Presumably there was a reason for this.

@chuong98
Copy link

I am curiousl too, since the original paper proposed the Micro-block as: BN-Act-Conv2d. This is also replicated by other pytorch implementation, and also used in DenseNet.
However, the ResNeXt uses Conv2d-BN-Act.
So between the two implementations, the Conv2d is missing at the first block. Can you explain?

@relh
Copy link

relh commented Oct 18, 2018

When BN-Act comes first it adds batch norm and an activation to the input images.

At least that's one reason one might write your helper function thus. Obviously when tiled, these layers look similar for most of the network.

There's lots of interesting ways to style residual blocks. We may as well be doing it like NAS does it when we design networks.

@chuong98
Copy link

Hi thanks Relh.
Actually, in the paper "Identity mappings in deep residual networks", He et al. examined several structures, include BN-Act-Cov, and Cov-Bn-Act, and found that the structure BN-Act-Conv is better.
However, later in ResNeXt, they changed back to Conv-Bn-Act.
Now, there are discussion that Act-Bn is better than Bn-Act. I guess NAS can choose the best structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants