diff --git a/.bazelrc.remote b/.bazelrc.remote index 6e5297ec11000..da8b844acfb02 100644 --- a/.bazelrc.remote +++ b/.bazelrc.remote @@ -31,7 +31,7 @@ build:rbe --disk_cache= build:rbe --incompatible_enable_cc_toolchain_resolution build:rbe --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 test:rbe --test_env=DISPLAY=:99.0 -test:rbe --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote +test:rbe --test_tag_filters=-exclusive-if-local,-remote # Env vars we can hard code build:rbe --action_env=HOME=/home/dev diff --git a/cpp/iedriver/Alert.cpp b/cpp/iedriver/Alert.cpp index 7e04e273155a7..a267f216a987c 100644 --- a/cpp/iedriver/Alert.cpp +++ b/cpp/iedriver/Alert.cpp @@ -26,6 +26,7 @@ #define INVALID_CONTROL_ID -1 +// Changing this one for sure namespace webdriver { Alert::Alert(std::shared_ptr browser, HWND handle) { @@ -81,7 +82,7 @@ int Alert::Accept() { LOG(INFO) << "OK button does not exist on dialog; looking for Cancel button"; button_info = this->GetDialogButton(CANCEL); } - + if (!button_info.button_exists) { LOG(WARN) << "OK and Cancel button do not exist on alert"; return EUNHANDLEDERROR; @@ -239,7 +240,7 @@ std::string Alert::GetStandardDialogText() { &Alert::FindTextLabel, reinterpret_cast(&info)); } - + std::string alert_text_value; if (info.label_handle == NULL) { alert_text_value = ""; diff --git a/java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java b/java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java index 47c15536581b9..9ddc24f0a5f73 100644 --- a/java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java +++ b/java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java @@ -71,6 +71,19 @@ void testBasicKeyboardInput() { shortWait.until(ExpectedConditions.attributeToBe(input, "value", "abc def")); } + @Test + void testSomethingElse() { + driver.get(appServer.whereIs("single_text_input.html")); + + WebElement input = driver.findElement(By.id("textInput")); + + Actions sendLowercase = getBuilder(driver).sendKeys(input, "12345"); + + inputModule.perform(windowHandle, sendLowercase.getSequences()); + + shortWait.until(ExpectedConditions.attributeToBe(input, "value", "12345")); + } + @Test @NotYetImplemented(SAFARI) public void testSendingKeyDownOnly() {