[BUG] skip_annotations: true still posts annotations

[rtizzy]

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

When setting skip_annotations to true, annotations are still posted into the PR

To Reproduce

Try the following config for this action

      - name: ESLint changed files with Reviewdog
        uses: tj-actions/eslint-changed-files@v21
        with:
          reporter: github-pr-review
          skip_annotations: true
          filter_mode: file
          config_path: ".eslintrc.json"
          ignore_path: ".eslintignore"
          extra_args: "--rulesdir eslint-rules"
          fail_on_error: true

Create a file that fails linting

let not_a_number: string = 12
let not_a_string: number = "sup"

Create a PR and annotations are posted.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-22.04

Expected behavior?

eslint runs and otherwise fails if relevant but does not post any annotations.

Relevant log output

N/A

Has all relevant logs been included?

• I've included all relevant logs

Anything else?

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

[jackton1]

Hi @rtizzy can you enable debug mode and include the relevant log output

[jackton1]

Closing this issue as there has been no response and I’m unable to reproduce it

[kabamccortesdelafuente]

Hello @jackton1 I'm facing this issue as well with the following config:

- name: ESLint changed files
        uses: tj-actions/eslint-changed-files@v25
        with:
          skip_annotations: true
          fail_on_error: true
          file_extensions: '**/*.{js,ejs}'
          token: ${{ secret }}

And I'm still getting the PR annotations

How can I enable the debug mode?

Here's part of the logs I can see from my action

# Run eslint on changed files
  bash $GITHUB_ACTION_PATH/entrypoint.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_SERVER_URL: https://github.com
    GITHUB_BASE_REF: ***
    GITHUB_HEAD_REF: ***
    INPUT_TOKEN: ***
    REVIEWDOG_GITHUB_API_TOKEN: ***
    INPUT_PATH: .
    INPUT_LEVEL: error
    INPUT_ALL_FILES: false
    INPUT_CONFIG_PATH: 
    INPUT_CHANGED_FILES: ***
    INPUT_EXTRA_ARGS: 
    INPUT_FILTER_MODE: added
    INPUT_FAIL_ON_ERROR: true
    INPUT_REPORTER: github-pr-review
    INPUT_SKIP_ANNOTATIONS: true

# eslint-changed-files
  Resolving repository path: /home/runner/work/***
  Running ESLint on changed files...
  Skipping annotations...

  ✖ 17 problems (7 errors, 10 warnings)
    0 errors and 10 warnings potentially fixable with the `--fix` option.
  
  Error: Error running eslint.
Error: Process completed with exit code 1.