Skip to content

Migration down does not work correctly #172

@xfg

Description

@xfg

Hello. I created the test repo on which I am testing the current library.

I run migrate up command and get next output

up : 1585061628701-1.js
up 1 migration
  up : 1585061705214-2.js
up 2 migration
  up : 1585061975014-3.js
up 3 migration
  migration : complete

Everything works as it should but now I run migrate down 1585061705214-2 and get

down : 1585061975014-3.js
down 3 migration
  migration : complete

It is not right since the 1585061705214-2 migration should have rolled back too based on this quote from the documentation

Similarly you can run down-migrations up to (and including) a specific migration

and if after it I run migrate down 1585061975014-3 which was rolled back above I get

down : 1585061705214-2.js
down 2 migration
  migration : complete

That's very strange.

And the last.

If we have two branches and the migrations 1585061628701-1 and 1585061975014-3 were created and applied in first branch, and the migration 158506170521414-2 was created in the other branch, which was created earlier than 1585061975014-3, then when the second branch merges with the first and call migrate up and then migrate down 1585061705214-2 everything will break down and we won’t be able to roll back to any specific migration except migrate down.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions