Skip to content

Commit feec15e

Browse files
committed
Hotfix: Fix invalid query when killing submissions
This fixes the below production error: ``` File ".../tin/tin/apps/submissions/views.py", line 106, in kill_view submission = get_object_or_404(submissions_editable, id=submission_id) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../site-packages/django/shortcuts.py", line 85, in get_object_or_404 return queryset.get(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../site-packages/django/db/models/query.py", line 640, in get raise self.model.MultipleObjectsReturned( tin.apps.submissions.models.Submission.MultipleObjectsReturned: get() returned more than one Submission -- it returned 5! ``` One solution would have been to append a `.distinct()` to the query, but instead it was replaced by `filter_visible()` for consistency.
1 parent 9e906c1 commit feec15e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tin/apps/submissions/views.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,9 @@ def kill_view(request, submission_id):
9999
request: The request
100100
submission_id: An instance of the :class:`.Submission` model
101101
"""
102-
submissions_editable = Submission.objects.filter(
103-
Q(assignment__course__teacher=request.user) | Q(student=request.user)
102+
submission = get_object_or_404(
103+
Submission.objects.filter_visible(request.user), id=submission_id
104104
)
105-
submission = get_object_or_404(submissions_editable, id=submission_id)
106105

107106
if request.method == "POST":
108107
submission.kill_requested = True

0 commit comments

Comments
 (0)