Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows support #1

Open
tkadur opened this issue Aug 17, 2019 · 1 comment
Open

Fix Windows support #1

tkadur opened this issue Aug 17, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tkadur
Copy link
Owner

tkadur commented Aug 17, 2019

The only thing blocking it from compiling on Windows is a call to std::os::unix::fs::symlink in the linker. This is easily fixable. In particular, the following function needs to be implemented for Windows:

dotman/src/linker/mod.rs

Lines 45 to 48 in efb0192

#[cfg(unix)]
fn symlink(source: impl AsRef<Path>, dest: impl AsRef<Path>) -> io::Result<()> {
std::os::unix::fs::symlink(source, dest)
}

As for testing that all behavior is correct on Windows, see #2.

@tkadur tkadur added the enhancement New feature or enhancement of existing feature label Aug 17, 2019
@tkadur tkadur self-assigned this Aug 17, 2019
@tkadur tkadur added bug Something isn't working and removed enhancement New feature or enhancement of existing feature labels Dec 20, 2019
@tkadur
Copy link
Owner Author

tkadur commented Dec 20, 2019

This is really more of a bug, since Windows support has always been intended but not implemented.

@tkadur tkadur added the good first issue Good for newcomers label Dec 20, 2019
@tkadur tkadur changed the title Add Windows support Fix Windows support Dec 20, 2019
@tkadur tkadur removed their assignment Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant