Proposal: add actions/stale to help us reminding about open PRs

[sebastiaanspeck]

https://github.com/actions/stale

name: "Mark stale PR"
on:
  schedule:
  - cron: "0 0 1 * *"

  workflow_dispatch:

jobs:
  stale:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/stale@v9
      with:
        stale-pr-message: "This PR hasn't received any updates in two weeks. We will mark this PR as `review needed`, purely to bring attention to our reviewers. It will not be closed automatically."
        days-before-stale: -1
        days-before-close: -1
        days-before-pr-stale: 14
        remove-pr-stale-when-updated: true

[kbdharun]

Hi, I wouldn't suggest bringing back the stale action even in a fine-tuned way given the previous experiences we had with it, since some PRs are intentionally left unmerged/unreviewed for a while due to various reasons like waiting for author's feedback, etc.

---

If others think this is required, then I would suggest adding a review-required label alone rather than commenting.

[sebastiaanspeck]

Looking at the bunch of PRs we sometimes have, and the small amount of PRs that are intentionally left unmerged/unreviewed, I still would suggest to add this. We could only add a label to the configuration.

name: "Mark PRs as review needed"
on:
  schedule:
  - cron: "0 0 1 * *"

  workflow_dispatch:

jobs:
  stale:
    name: "Mark PRs as review needed"
    runs-on: ubuntu-latest
    steps:
    - uses: actions/stale@v9
      with:
        stale-pr-label: "review needed"
        days-before-stale: -1
        days-before-close: -1
        days-before-pr-stale: 14
        remove-pr-stale-when-updated: true

[acuteenvy]

I don't think it's necessary, but as long as it doesn't automatically close PRs like before, I'm fine with it.

[acuteenvy]

Since this is a proposal to assign "review needed" labels, and now that label is being used for translation PRs without a CODEOWNER (tldr-pages/tldr-labeler-action#37), is this still relevant?

@sebastiaanspeck

[sebastiaanspeck]

Since this is a proposal to assign "review needed" labels, and now that label is being used for translation PRs without a CODEOWNER (tldr-pages/tldr-labeler-action#37), is this still relevant?

@sebastiaanspeck

I think not. We can close this issue.