identifier quote check is incorrect when passing mixed-case names

[urkle]

the identifier function checks to see if the passed identifier contains non alpha and non-numeric contents. However it should be checking the case of the alpha characters as well.

# what it does right now
identifier('myAwesomeTable') == 'myAwesomeTable'
# what it should do
identifier('myAwesomeTable') == '"myAwesomeTable"'

Otherwise Postgres case-folds the identifier (myAwesomeTable -> myawesometable) and the select query fails.

[tlocke]

Hi @urkle, thanks for raising this. On balance I think you're right, so I've changed the behaviour here 91b0094

[urkle]

@tlocke thanks for the quick response!.

Generally IMO I just have quote everything 100% of the time but this change should work fine.

[tlocke]

You're right, I think it's best if it just quotes everything, so I've made that change 0a75f1c