Correction: Add _readiness_ probe for deploy downtime

Keep liveness probe just in case.

fbshipit-source-id: 0768e85

Author: nicknovitski

deploy.sh

@@ -6,10 +6,8 @@ environment=$1
 
 if [ "$environment" == "production" ]; then
   export INGRESS_HOSTNAME=docs.expo.io
-  export ENVIRONMENT=production
 elif [ "$environment" == "staging" ]; then
   export INGRESS_HOSTNAME=staging.docs.expo.io
-  export ENVIRONMENT=staging
 else
   echo "Unrecognized environment $environment"
   exit 1

docs.k8s.template.yml

@@ -3,7 +3,6 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: docs
-  namespace: ${ENVIRONMENT}
   labels:
     app: docs
 spec:
@@ -31,11 +30,17 @@ spec:
           ports:
           - containerPort: 80
             name: http
+          readinessProbe:
+            httpGet:
+              path: "/"
+              port: 3000
+            initialDelaySeconds: 1
           livenessProbe:
             httpGet:
               path: "/"
               port: 3000
-            initialDelaySeconds: 5
+            initialDelaySeconds: 10
+            timeoutSeconds: 2
           resources:
             requests:
               cpu: 200m
@@ -45,7 +50,6 @@ apiVersion: v1
 kind: Service
 metadata:
   name: docs
-  namespace: ${ENVIRONMENT}
   labels:
     app: docs
 spec:
@@ -60,7 +64,6 @@ apiVersion: extensions/v1beta1
 kind: Ingress
 metadata:
   name: docs
-  namespace: ${ENVIRONMENT}
   labels:
     app: docs
     ssl: "true"