-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ScalaJS #33
Comments
ScalaJS would make the build matrix much larger, and consequently would cause an explosion in build times. I'd be happy to support this, but only if someone actually has a use for it. If anyone does want to use libra with ScalaJS, please comment here. |
Build times tend to be larger for scala.js in any case and i guess it will double the matrix size right? i haven't followed this up as i wasn't able to update singleton-ops but now that you did I may give it a try |
Yes, it would double the build times. Our build times are pretty small compared to most projects (5 - 6 minutes), so I'm happy to double them as long as someone has a use case. Adding ScalaJS should be fairly straightforward. |
The changes aren't that big but i'm having troubles running tests on the JS side. I'll let you know if I can make it work |
I needed this and have a working implementation apart from a single failing test. The new directory layout would be:
If this sounds ok I'd be happy to wrap it up in a PR I have submitted an idea (#108) which I think would provide another way to solve the platform differences (with the help of |
Turns out platform specific code isn't required. Doubles just have to be formatted with something like An alternative view is that nice & predictable formatting isn't (at least not yet) an important feature. After all, |
I have submitted a PR. However, I did run into a few issues, mostly around the microsite in combination with cross-compilation. Tried fixing them with minimal dependency upgrades but ran into even more incompatibility issues. I could only make it work by upgrading the Scala versions as well as many other dependencies of the project. |
This has been merged in 🎉 |
This has been release in v0.7.0. Thanks @maekl ! Please feel free to open a PR and add yourself to the list of contributors |
This follows from a discussion with @cquiroz about Libra adoption.
Potentially many users need ScalaJS support.
Spire, shapeless and singleton-ops all support this, so it should be trivial to add.
The text was updated successfully, but these errors were encountered: