Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history and commit quality #174

Open
andreineculau opened this issue Jun 26, 2020 · 0 comments
Open

history and commit quality #174

andreineculau opened this issue Jun 26, 2020 · 0 comments

Comments

@andreineculau
Copy link
Contributor

andreineculau commented Jun 26, 2020

Hello Tobians! 👋

I was ready to merge your history into my fork, but it quickly became obvious that it's questionable if I should actually do it from a ROI perspective. It's great to see activity in this repo 👏 but there's a bunch of things that have been done that make it very hard to keep track and analyze whether it's worthwhile to merge the history or cherry-pick useful commits. Some examples:

  • 381aea0 renamed a bunch of files, simply because the brew-* files started doing more than just calling brew?! 🤔
  • a series of commits started installing things with aptitude or pip, not brew, without giving a reason to it
  • removed building xenial images - why? 🤷 That also means that whenever someone wants to update support-firecloud in a repo like lodash-firecloud, will also be confused at first and forced to use bionic in their .travis.yml
  • many commits say one things, but do more than one thing, like
  • using less of linuxbrew in favour of aptitude on linux without a reason. This inherently means packages will risk having different versions on a linux machine than on a macos machine, like a1decc8 - some differences will be irrelevant, but some others not so much. The goal with using linuxbrew WAS to align as much as possible the linux and macos machines, and to make it easier for someone to install packages since sometimes brew install foo cannot be simply replaced with apt install foo

FWIW I'm going to be active on https://github.com/rokmoln/support-firecloud , more active maybe in the months to come. But it doesn't look like we're aligned on NOT making breaking changes without good motivations. I just wanted to reach out before it's too late, in case there's a change of heart.

Keep up the good work, and all the best at Tobii and at home!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant