Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

og:locale:alternate -> $lang->locale(LC_ALL) #103

Open
wdebusschere opened this issue Jul 12, 2024 · 0 comments
Open

og:locale:alternate -> $lang->locale(LC_ALL) #103

wdebusschere opened this issue Jul 12, 2024 · 0 comments
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@wdebusschere
Copy link

I think the og:local:alternate should be the full locale

<meta content="cs" property="og:locale:alternate">
<meta content="nl" property="og:locale:alternate">
<meta content="en_US" property="og:locale">

=>

<meta content="cs_CZ" property="og:locale:alternate">
 <meta content="nl_NL" property="og:locale:alternate">
<meta content="en_US" property="og:locale">

Code

if ($lang !== kirby()->language()) {
    $meta['og:locale:alternate'][] = fn () => $lang->code();
}

=>

if ($lang !== kirby()->language()) {
    $meta['og:locale:alternate'][] = fn () => $lang->locale(LC_ALL);
}
@tobimori tobimori added the type: bug 🐛 Is a bug; fixes a bug label Jul 12, 2024
@tobimori tobimori added this to the 2.0.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants