Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field label language fallback doesn't work #120

Open
olach opened this issue Nov 7, 2024 · 2 comments
Open

Field label language fallback doesn't work #120

olach opened this issue Nov 7, 2024 · 2 comments

Comments

@olach
Copy link
Contributor

olach commented Nov 7, 2024

If the panel user has a language that is not included as a translation for this plugin, the field labels shows the label keys instead of a fallback translation.

To reproduce:

  • For the currently logged in user, set the user language to a language that is not supported by this plugin, i.e. Swedish.
  • Go to a page and show the SEO tab.
  • All field labels shows the label key: global-meta-headline, meta-title-template, meta-title-template-help, meta-description etc

image

I would rather see that if the user language is not supported, the fallback would be shown with English translation.

@tobimori
Copy link
Owner

tobimori commented Nov 7, 2024

This doesn't seem like a plugin issue but rather an issue of core. Surely it should work by default?
getkirby/kirby#1188

@olach
Copy link
Contributor Author

olach commented Nov 7, 2024

I was also thinking it might be a Kirby issue. Forgot to mention that. But because of this issue I took the time to make a PR with a swedish translation. So something good came out of it. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants