feat(optimizer)!: annotate types for Snowflake BIT_LENGTH function #5927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-BradfordPaskewitz
requested review from
georgesittas and
fivetran-amrutabhimsenayachit
geooo109
reviewed
Sep 19, 2025
I searched the codebase and didn't see any other usages of BIT_LENGTH, is there anything else to do for that? |
fivetran-BradfordPaskewitz
force-pushed
the
brad/bit_length
branch
from
e04c684 to
9b02cf9
Compare
fivetran-BradfordPaskewitz
force-pushed
the
brad/bit_length
branch
from
9b02cf9 to
f9871ab
Compare
georgesittas
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links: https://fivetran.atlassian.net/browse/RD-1036067
Documentation: https://docs.snowflake.com/en/sql-reference/functions/bit_length