Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby #286

Open
hyandell opened this issue Mar 23, 2023 · 3 comments
Open

Drop Ruby #286

hyandell opened this issue Mar 23, 2023 · 3 comments
Labels
ruby Pull requests that update Ruby code

Comments

@hyandell
Copy link
Member

Issue Report

Licensee and Linguist are used as axioms to allow some linting rules to only apply when the output of those tools match the license or language. Unfortunately, both are written in Ruby which doubles the tech-stack complexity of the project. I'm not aware of anyone actively using these axioms and so my proposal is that we drop these.

@justinabrahms
Copy link
Member

When I run repolinter, I pay attention to the axiom gated results.

We could probably do just as well as linguist (for my needs at least) by looking at file extensions.

@hyandell
Copy link
Member Author

hyandell commented Mar 27, 2023

Agreed. https://www.npmjs.com/package/linguist-js is also an option. Sounds like it's built on the rules for github linguist, but not the ruby code.

Licensee wise, losing the axiom would lose the apache-notice rule and the license-detectable-by-licensee rule; though the latter is off by default.

@Brend-Smits
Copy link
Collaborator

Losing the license check would be a shame, have to see if we can find a replacement for this package.
It would be fantastic if the axioms could just be given their own home in a new repository, and we can just use them plugin-style. I understand that this might be challenging with the current architecture.

@hyandell hyandell added the ruby Pull requests that update Ruby code label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

3 participants