-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gRPC multixplex example for axum 0.7 and hyper 1 #2736
Comments
I'll try to make it work this week. |
Has there been any progress on this? |
There has been progress on hyperium/tonic#1670, and once that is merged and released, this sounds be pretty simple to do. |
The tonic PR has been merged — if anyone isn't working on updating the example I'll give it a shot! |
I think you can go ahead, just note that while the PR has been merged, new version is not yet released and there might be a few more breaking changes. But feel free to go ahead, I wouldn't expect any other large changes that should influence the example, just so you know. |
@mladedav I'll probably just open a draft pr with a git dependency, then. |
Feature Request
Update example
rest-grpc-multiplex
Motivation
Currently, the example code in https://github.com/tokio-rs/axum/tree/main/examples/rest-grpc-multiplex is commented out
and marked as TODO.
The code in the example is not really straight forward for beginners and can be a good starting point for learning exercises.
Proposal
Update the code to be compatible with axum 0.7 and hyper 1.
The text was updated successfully, but these errors were encountered: