-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose UTF-8 validated string type #697
Comments
cc @LucioFranco |
My initial feeling is that I wouldn't want to add such a large new type to the public API of the crate. I can imagine a lot of requests for what a But our maintenance availability is quite limited. |
I'm wondering if a good compromise would be to have a crate For example, this new crate could offer functionalities like https://github.com/vorner/bytes-utils does (although I don't have an opinion about the implementation of that specific crate). |
bytes
has become a little bit of a de facto standard for low/zero-copy techniques, with authors of some popular crates being comfortable with exposingbytes
types in their interfaces. In some cases, those crates would benefit from a bytes string wrapper to enable zero-copy string handling, but they don't support such handling becausebytes
doesn't and they don't want to include another crate likebytestring
, which isn't a de facto standard as of now, in their interfaces.For example,
prost
, which implements conversion between Rust types and protocol buffers, supports usingBytes
instead ofVec<u8>
to back protobuf bytes fields, but it doesn't a similar alternative forString
, despite it being a requested feature (tokio-rs/prost#752), in part becausebytes
doesn't have a string wrapper type.Would the
bytes
maintainers be open to exposing such a type, along the lines of the one described in #373, in order to better enable these use cases in the ecosystem?The text was updated successfully, but these errors were encountered: