Re-export bytes crate?

[0x6273]

Should the bytes crate be re-exported, since the Bytes type is used in public api? Currently, users have to add bytes as a dependency in their Cargo.toml, and match the version so that the types are the same. See Tokio tutorial "Add bytes dependency" secton for an example of what I mean.

[Darksonn]

There are lots of crates with bytes in the public api that don't reexport it. Is there any particular reason it is more important for mini-redis?

[0x6273]

I think the main reason is ease of use. Figuring out what version of bytes is required and adding it as a separate dependency is an extra hurdle when using mini-redis. It's also generally considered to be best practice to re-export crates that are needed to use the public api. Is there any reason we don't want to do this?

[Darksonn]

You say it is generally considered to be best practice, but I've never heard of it before, and I'm certainly not new to Rust.

In any case, I think it's fine to have people add the dependency. One of the things the tutorial should teach is the ecosystem you will be using when writing networking applications, and bytes is an integral part of that ecosystem, which you will almost certainly need to import in your own networking projects.

On the other hand, mini-redis is an incomplete example of idiomatic code, and shouldn't generally be used in your own projects. I don't want to introduce any confusion about whether bytes is something you should be using, and I think importing it through mini-redis could introduce such confusion, precisely because you aren't supposed to use mini-redis in real code.