Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguity in TcpStream::try_write_vectored docs #7067

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix ambiguity in TcpStream::try_write_vectored docs #7067

merged 1 commit into from
Jan 6, 2025

Conversation

AeonSolstice
Copy link
Contributor

Motivation

The buffer cannot be possible.

Solution

Make it clear that the last buffer that is read from by the method, may have only been partially read.

As a side note, does the method override the buffers' contents? If not, then "consumed" should be replaced with "written".

@Darksonn Darksonn added T-docs Topic: documentation A-tokio Area: The main tokio crate M-net Module: tokio/net labels Jan 6, 2025
Darksonn
Darksonn approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 67f1277 into tokio-rs:master Jan 6, 2025
88 checks passed
@Darksonn Darksonn mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AeonSolstice @Darksonn