Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run Pieman from any directory #265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eugulixes
Copy link
Contributor

@eugulixes eugulixes commented Jul 13, 2020

Closes #239


Please make sure all below checkboxes in the Mandatory section have been checked before submitting your PR (also don't forget to pay attention to the Depending on Circumstances section)

Mandatory

  • The commit message is an imperative and starts with a capital letter (for example, Add something, Remove something, Fix something, etc.).
  • I made sure I hadn't put a period at the end of the the commit message(s).

Depending on Circumstances

Some of the items in the section become mandatory if you are a first-time contributor and/or your changes are relevant to the items.

  • Adding a new parameter I didn't forget to reflect it in README.md.
  • Adding a new parameter or modifying an existing one I didn't break the alphabetical order.
  • Adding a new utility written in Python I didn't forget to reflect it in pieman/README.md.
  • Adding a new utility written in Python I didn't forget to increase the version number of the pieman package in pieman/setup.py, pieman/pieman/__init__.py and essentials.sh.
  • (for first-time contributors) One of the commits in the pull request adds me to the Acknowledgements section in AUTHORS.md.

@eugulixes eugulixes force-pushed the feature/run-pieman-from-any-directory branch from cded3e7 to f8f8da4 Compare July 14, 2020 06:44
Base automatically changed from improvement/get-rid-of-PIEMAN_UTILS_DIR to master July 15, 2020 18:01
@eugulixes eugulixes force-pushed the feature/run-pieman-from-any-directory branch from f8f8da4 to aab2f92 Compare July 15, 2020 18:39
@eugulixes eugulixes force-pushed the feature/run-pieman-from-any-directory branch from aab2f92 to 14b9ae5 Compare July 18, 2020 15:41
@karpa4o4 karpa4o4 force-pushed the feature/run-pieman-from-any-directory branch from 292f100 to 5f74434 Compare July 24, 2020 11:10
@@ -19,7 +19,11 @@ if [ "$(id -u)" -ne "0" ]; then
exit 1
fi

. ./essentials.sh
PIEMAN_DIR=${PIEMAN_DIR:=$( dirname "$(readlink -f "$0")" )}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIEMAN_DIR="$( dirname "$(readlink -f "$0")" )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to run Pieman from any directory
2 participants