Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting enchanted items from the storage removes enchantment from the item #376

Closed
JowMK opened this issue Jun 6, 2024 · 1 comment
Closed

Comments

@JowMK
Copy link

JowMK commented Jun 6, 2024

Issue

I observed the issue from the prominence 2 pack, where items from the MC Dungeons Weapons that normally has enchantments by default when crafting them, didn't have the enchantments.

It seems to have some sort of incompatibility with the Tierify mod that alters the item name and attributes since one item that (for some reason) didn't get the affix applied resulted in it having the enchantments that it should.

Expected result:

The crafted item either shows the enchantment in the product slot of the crafting terminal or the enchantments gets applied once the item is crafted

Versions

Mod version: 1.6.5
Modpack: Prominence 2 [RPG]
Modpack Version: v2.8.6hf

Steps to reproduce:

Missing enchantments

  1. Setup a Crafting Terminal
  2. Craft [Any enchanted item from MC Dungeons Weapons/Armor]
  3. Item has no enchantments in crafting interface nor in the crafted item

Has Enchantment

  1. Setup a Crafting Terminal
  2. Craft Soul Sucker Boots from Nether Depths Update mod (Has Soul Speed 3)
  3. Item shows no enchantments in the crafting interface but the item has enchantments applied
@tom5454
Copy link
Owner

tom5454 commented Jun 20, 2024

The enchantments are applied with a mixin into the crafting table menu, it'll break with every other modded crafting system. This is a bug with MC Dungeons Weapons (chronosacaria/MCDungeonsWeapons#276).

@tom5454 tom5454 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants